Fix color object guideline from math glyph#851
Merged
typesupply merged 4 commits intomasterfrom Aug 14, 2025
Merged
Conversation
and if it is not a tuple, try if it is a defcon color object and if it is not a defcon object, discard the color but please don't crash.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #851 +/- ##
==========================================
- Coverage 78.31% 78.25% -0.07%
==========================================
Files 41 41
Lines 6107 6112 +5
Branches 916 917 +1
==========================================
Hits 4783 4783
- Misses 1117 1122 +5
Partials 207 207
🚀 New features to boost your workflow:
|
typesupply
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your consideration. This addresses issue #850.
Summary: during fromMathGlyph, a guideline can have a color that can be a defcon color object rather than a tuple. This adds some resilience without creating too many expectations or dependency on defcon.
This is a small but annoying issue that in effect requires all guidelines to be removed from source glyphs before starting calculations.