Skip to content

Use respondsToSelector instead of hasattr in _breakCycles. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
typesupply wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use respondsToSelector instead of hasattr in _breakCycles. #200

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f22491
Use respondsToSelector instead of hasattr in _breakCycles.
typesupply Dec 20, 2023
07cb872
Merge pull request #221 from robotools/master
typesupply Jan 24, 2025
d2c4d47
Test for None.
typesupply Jan 24, 2025
0f48bd1
Handle a couple of situations.
typesupply Jan 24, 2025
1ab15a2
The NSObject test shouldn't be necessary.
typesupply Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Lib/vanilla/vanillaBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,8 @@ def _breakCycles(view):
"""
Break cyclic references by deleting _target attributes.
"""
if hasattr(view, "vanillaWrapper"):
if view.respondsToSelector_("vanillaWrapper"):
obj = view.vanillaWrapper()
if hasattr(obj, "_breakCycles"):
obj._breakCycles()
obj._breakCycles()
Copy link
Member

@typemytype typemytype Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the vanillaWrapper object could be None, fe when weakref has no reference of that object anymore

testing if obj is not None: will not slow down breakCycles

for view in view.subviews():
_breakCycles(view)