fix #197

[SnappyRiffs]

fixed issue #197-combined level two and level three into one function

[gemini-code-assist]

Summary of Changes

Hello @SnappyRiffs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #197 by performing a significant refactoring within the SuperStructure subsystem. The core change involves consolidating the previously separate coralLevelTwo and coralLevelThree command sequences into a single, parameterized function named coralLevelTwoThree. This change aims to eliminate redundant code, centralize the logic for similar scoring levels, and improve the overall maintainability and readability of the codebase.

Highlights

• Code Refactoring: The coralLevelTwo and coralLevelThree command sequences have been refactored into a single, more generic function to reduce code duplication.
• New Function Introduction: A new function, coralLevelTwoThree, was introduced to encapsulate the common logic for both coral scoring levels, accepting parameters for pre-position, preset level, and naming.
• Parameterization: Hardcoded values and strings within the original coralLevelTwo and coralLevelThree logic have been replaced with parameters in the new coralLevelTwoThree function, making it more flexible.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the coralLevelTwo and coralLevelThree methods by extracting their common logic into a new coralLevelTwoThree helper method. This is a good change that reduces code duplication. However, the refactoring has introduced a minor regression where the command names for level 2 and 3 scoring are changed. My review includes suggestions to fix the command names to restore the original behavior and improve consistency.

[markpete]

There is still more opportunity for removing redundant code.

HINT: ipScore = () -> { return true; }

[markpete]

See if you can remove redundancy on this function too, by having it call the new routine.

HINT: ipScore = () -> { return true; }

[markpete]

This routine should be able to leverage the new shared code you wrote as well.

[markpete]

You should also be able to combine the two coralLevelOne Commands.