Skip to content

Comments

Modernize Gradle configuration#211

Merged
markpete merged 7 commits intomainfrom
markpete/build-improvements
Dec 2, 2025
Merged

Modernize Gradle configuration#211
markpete merged 7 commits intomainfrom
markpete/build-improvements

Conversation

@markpete
Copy link
Contributor

Modernize Gradle configuration by introducing version catalogs, setting build properties, and updating Java toolchain.

This should simplify config management and speed up build times.

… setting build properties, and updating Java toolchain.
@gemini-code-assist
Copy link

Summary of Changes

Hello @markpete, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly modernizes the project's Gradle configuration. The primary goal is to streamline dependency and plugin management, enhance build performance through optimized properties, and ensure a consistent Java development environment. These changes aim to simplify future maintenance and provide a more efficient build process.

Highlights

  • Gradle Version Catalogs: Introduced Gradle Version Catalogs by adding gradle/libs.versions.toml, centralizing dependency and plugin versions for easier management and consistency across the project.
  • Gradle Build Properties: Added gradle.properties to configure essential build properties, including enabling build caching, parallel execution, and setting JVM memory arguments, aiming to improve build performance.
  • Java Toolchain Configuration: Updated the build.gradle file to use Gradle's java.toolchain block for specifying Java 17, ensuring consistent and reproducible builds across different environments.
  • Foojay Toolchains Resolver: Integrated the org.gradle.toolchains.foojay-resolver-convention plugin in settings.gradle to enhance Java toolchain resolution capabilities.
  • Build Info Script Refinement: Improved the buildinfo.gradle script by modernizing the hasGit function for more robust Git executable detection and refactoring file output using PrintStream.withStream.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of modernizing the Gradle configuration by introducing a version catalog, setting up a Java toolchain, and adding standard build performance properties. These changes will definitely simplify dependency management and improve build times. I've added a couple of suggestions to the libs.versions.toml file to further improve its maintainability.

markpete and others added 6 commits November 26, 2025 11:17
Collapsing errorproneCore and errorproneAnnotations to just errorprone, so that they stay in sync.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@koolpoolo koolpoolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as it centralizes the versions as well which is nice to have them in one neat place

@markpete markpete merged commit eec781e into main Dec 2, 2025
2 checks passed
@markpete markpete deleted the markpete/build-improvements branch December 2, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants