Support pickling geometry types #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great idea. It would be good to add tests to round-trip the data to ensure it's actually correct and doesn't accidentally break in the future. |
|
Please rebase against main. |
|
👋 hi @mailmindlin, were you interested in getting this change in this season? |
|
We can't merge this without tests, sorry. Definitely interested in the functionality if you (or someone else) decides to pick this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the geometry types in
wpimath.geometrypackage can't be pickled. This is especially useful for compatibility with other python libraries (e.g., multiprocessing).NB: I wasn't sure what the standard for PRs is (should I make this PR into
mainor2025-beta-3?).