Rename geometry from matrix constructor overloads #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- build-system.requires: robotpy-build<2025.0.0b1,~=2025.0.0a8
auscompgeek
force-pushed
the
geom-from-matrix
branch
from
a5714f5 to
0dd99d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #119 for context.
Declaring numpy as a dependency is a no-go, but also we want to avoid importing numpy where possible. When using OpenBLAS (as we do for the roboRIO) importing numpy will initialise OpenBLAS, and OpenBLAS will allocate memory regions, which adds memory pressure.
Also, disable the keepalive inference for the various geometry constructors. These references aren't held after the constructor returns.
Depends on: