Skip to content

SimDevice: only release GIL when calling API #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

SimDevice: only release GIL when calling API #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions subprojects/robotpy-hal/gen/SimDevice.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,12 @@ inline_code: |
.def_property("value", &SimBoolean::Get, &SimBoolean::Set, release_gil())
.def("__repr__", [](const SimBoolean &self) -> py::str {
if (self) {
py::gil_scoped_release release;
return std::string("<SimBoolean value=") + (self.Get() ? "True" : "False") + ">";
bool value;
{
py::gil_scoped_release release;
value = self.Get();
}
return std::string("<SimBoolean value=") + (value ? "True" : "False") + ">";
} else {
return "<SimBoolean (invalid)>";
}
Expand All @@ -274,8 +278,12 @@ inline_code: |
if (!self) {
return "<invalid>";
} else {
py::gil_scoped_release release;
return HALSIM_GetSimDeviceName(self);
const char *name;
{
py::gil_scoped_release release;
name = HALSIM_GetSimDeviceName(self);
}
return name;
}
#endif
})
Expand All @@ -299,8 +307,12 @@ inline_code: |
.def_property("value", &SimDouble::Get, &SimDouble::Set, release_gil())
.def("__repr__", [](const SimDouble &self) -> py::str {
if (self) {
py::gil_scoped_release release;
return "<SimDouble value=" + std::to_string(self.Get()) + ">";
double value;
{
py::gil_scoped_release release;
value = self.Get();
}
return "<SimDouble value=" + std::to_string(value) + ">";
} else {
return "<SimDouble (invalid)>";
}
Expand Down Expand Up @@ -339,8 +351,12 @@ inline_code: |
.def_property("value", &SimInt::Get, &SimInt::Set)
.def("__repr__", [](const SimInt &self) -> py::str {
if (self) {
py::gil_scoped_release release;
return "<SimInt value=" + std::to_string(self.Get()) + ">";
int32_t value;
{
py::gil_scoped_release release;
value = self.Get();
}
return "<SimInt value=" + std::to_string(value) + ">";
} else {
return "<SimInt (invalid)>";
}
Expand All @@ -350,8 +366,12 @@ inline_code: |
.def_property("value", &SimLong::Get, &SimLong::Set)
.def("__repr__", [](const SimLong &self) -> py::str {
if (self) {
py::gil_scoped_release release;
return "<SimLong value=" + std::to_string(self.Get()) + ">";
int64_t value;
{
py::gil_scoped_release release;
value = self.Get();
}
return "<SimLong value=" + std::to_string(value) + ">";
} else {
return "<SimLong (invalid)>";
}
Expand Down
Loading