Notifier: prevent SIGABRT when program exits #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
virtuald
commented
Feb 7, 2025
virtuald
commented
- This occurs because our notifier uses a python thread instead of a C++ thread, and (I think) Python tries to kill it via pthread_cancel, which causes a weird exception to occur, which causes SIGABRT when we try to acquire the GIL
- Instead we just hang the thread, an approach recently taken by python itself
- Long term we should switch back to a C++ thread
- Fixes [BUG]: SIGABRT in PyNotifier on sim exit #147
- This occurs because our notifier uses a python thread instead of a C++ thread, and (I think) Python tries to kill it via pthread_cancel, which causes a weird exception to occur, which causes SIGABRT when we try to acquire the GIL - Instead we just hang the thread, an approach recently taken by python itself - Long term we should switch back to a C++ thread - Fixes #147
auscompgeek
reviewed
Feb 8, 2025
| // when we try to obtain the GIL again | ||
| // - this is a daemon thread so it's fine? | ||
| // - Python 3.14 does this too | ||
| while(true) {} |
There was a problem hiding this comment.
FWIW it looks like CPython's PyThread_hang_thread either sleeps indefinitely or calls the pause syscall, rather than busy looping. Might be worth doing the same here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.