Skip to content

Conversation

@martincarapia
Copy link
Contributor

Fixes issue #3
All the example files are in their respective folder inside the examples folder in the root directory.

@auscompgeek
Copy link
Member

Are there any reasons why

  • the top-level directory is all caps?
  • each subdirectory has an example prefix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these Python examples are intended to have the executable bit set. Please don't remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find the executable bit set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot of file header in GitHub PR files view, with mode change highlighted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, how would I go about fixing that? I've never encountered that before. I'm sorry I'm new to that.

@martincarapia
Copy link
Contributor Author

I used caps so that it was obvious they where examples, and I used example prefix so that they weren't mistaken with the original core.

@virtuald
Copy link
Member

virtuald commented Apr 9, 2024

I used caps so that it was obvious they where examples, and I used example prefix so that they weren't mistaken with the original core.

I see your point, but I prefer examples/cscore

@martincarapia martincarapia force-pushed the refactoring branch 3 times, most recently from 0b19295 to e0b7ae6 Compare June 9, 2024 06:54
@auscompgeek auscompgeek linked an issue Nov 30, 2024 that may be closed by this pull request
@virtuald virtuald merged commit eeb8541 into robotpy:main May 8, 2025
@martincarapia martincarapia deleted the refactoring branch May 16, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move examples to root directory

3 participants