Skip to content

Allow disabling keepalive inference for constructors #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Allow disabling keepalive inference for constructors #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion robotpy_build/autowrap/cxxparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ def _on_class_method(

# automatically retain references passed to constructors if the
# user didn't specify their own keepalive
if is_constructor and not method_data.keepalive:
if is_constructor and method_data.keepalive is None:
for i, pctx in enumerate(fctx.filtered_params):
if pctx.full_cpp_type.endswith("&"):
fctx.keepalives.append((1, i + 2))
Expand Down
Loading