Skip to content

Upgrade to pybind11 v3 prerelease #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Upgrade to pybind11 v3 prerelease #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
213d4df
Upgrade to pybind11 v3 prerelease
virtuald Mar 18, 2025
8471838
Update tests for pybind11 v3
virtuald Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions robotpy_build/autowrap/render_pybind11.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ def cls_decl(r: RenderBuffer, cls: ClassContext):
class_params.append(
f"std::unique_ptr<typename {cls.full_cpp_name}, py::nodelete>"
)
else:
class_params.append("py::smart_holder")

if cls.trampoline:
class_params.append(cls.trampoline.var)
Expand Down
1 change: 0 additions & 1 deletion robotpy_build/command/build_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def _spawn(cmd):
self.compiler._rpy_spawn = self.compiler.spawn
self.compiler.spawn = _spawn
for ext in self.extensions:
ext.define_macros.append(("PYBIND11_USE_SMART_HOLDER_AS_DEFAULT", "1"))
if debug:
ext.define_macros.append(
("PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF", "1")
Expand Down
2 changes: 1 addition & 1 deletion robotpy_build/pybind11
Open in desktop
Submodule pybind11 updated 153 files
4 changes: 2 additions & 2 deletions tests/test_ft_docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_docstrings_meth():
def test_docstrings_meth_kwd():
assert inspect.getdoc(ft.DocClass.fn2) == inspect.cleandoc(
"""
fn2(self: rpytest.ft._rpytest_ft.DocClass, from_: int) -> None
fn2(self: rpytest.ft._rpytest_ft.DocClass, from_: typing.SupportsInt) -> None

Function with parameter that's a python keyword

Expand All @@ -51,7 +51,7 @@ def test_docstrings_meth_kwd():
def test_docstrings_meth_rename():
assert inspect.getdoc(ft.DocClass.fn3) == inspect.cleandoc(
"""
fn3(self: rpytest.ft._rpytest_ft.DocClass, ohai: int) -> None
fn3(self: rpytest.ft._rpytest_ft.DocClass, ohai: typing.SupportsInt) -> None

Function with renamed parameter

Expand Down