Skip to content

Conversation

@auscompgeek
Copy link
Member

This adds a way to add a callback for NT updates to tunables.

Ref: #133

This adds a way to add a callback for NT updates to tunables.
Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One objection I have with this implementation is adding an additional entry listener. As you add more of them it'll keep making callbacks more expensive (which is a problem with the current ntcore implementation... ).

@auscompgeek
Copy link
Member Author

@virtuald Now that we have pyntcore, do you still have objections to this?

@virtuald
Copy link
Member

Callbacks still have the same issue.

@auscompgeek auscompgeek marked this pull request as draft July 23, 2020 06:39
@auscompgeek auscompgeek added the magicbot magicbot package label Aug 16, 2020
Base automatically changed from master to main January 14, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

magicbot magicbot package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants