Skip to content

move variable resettting to periodics #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

move variable resettting to periodics #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea00c34
move variable resettting to periodics
LucienMorey Apr 28, 2025
d15cd42
move reset after robot periodic
LucienMorey Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions magicbot/magicrobot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,9 @@ def _do_periodics(self) -> None:
self.onException()
else:
setter(value)

for reset_dict, component in self._reset_components:
component.__dict__.update(reset_dict)

watchdog.addEpoch("@magicbot.feedback")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should've written a test for this, but this PR as proposed reintroduces what I considered a bug: the will_reset_to attributes shouldn't reset before robotPeriodic is called, since it can be useful to observe its value there, e.g. for logging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the thing after all periodics

Expand All @@ -748,6 +751,3 @@ def _enabled_periodic(self) -> None:
watchdog.addEpoch(name)

self._do_periodics()

for reset_dict, component in self._reset_components:
component.__dict__.update(reset_dict)
Loading