Migrate js-stubs from kotlin-js to kotlin-multiplatform with target js

[ragul-engg]

resolves #1887

---

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (4e482ed) to head (adf332a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1921   +/-   ##
=========================================
  Coverage     91.86%   91.86%           
  Complexity      120      120           
=========================================
  Files           455      455           
  Lines          5017     5017           
  Branches        240      240           
=========================================
  Hits           4609     4609           
  Misses          361      361           
  Partials         47       47           

Flag	Coverage Δ
current	91.48% <ø> (ø)
current_windows	90.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[robstoll]

@ragul-engg thanks for the changes. I think js-stubs was the only project using build-logic.kotlin-js. Could you please check if we can delete gradle/build-logic/dev/src/main/kotlin/build-logic.kotlin-js.gradle.kts

[ragul-engg]

Yeah, will look into that. BTW in console there is a different warning being produced do you have any idea about this ?

> Task :js-stubs:compileKotlinJs
w: Language version 1.4 is deprecated and its support will be removed in a future version of Kotlin

[ragul-engg]

Done as you have pointed out the gradle/build-logic/dev/src/main/kotlin/build-logic.kotlin-js.gradle.kts file is not used, have removed them

[robstoll]

Yeah, will look into that. BTW in console there is a different warning being produced do you have any idea about this ?

> Task :js-stubs:compileKotlinJs
w: Language version 1.4 is deprecated and its support will be removed in a future version of Kotlin

The warning is legit as we produce kotlin 1.4 compatible code. However, normally we suppress it. I guess some setup we had in build-logic.kotlin-js is missing now.

Thinking about it a bit more, we should not delete build-logic.kotlin-js -- sorry for the wrong suggestion 🙈
Instead you should use kotlin-js in js-stubs again and make the adjustments in kotlin-js, i.e base it on the multiplatform-convention.

[ragul-engg]

I did base the build-logic.kotlin-js on multiplatform-conventions. I am still seeing the same warning. I don't think we have anything specific to suppress those compileKotlinJs warnings in kotlin-js previously. Dropping the file for reference, I just replaced it to refer the mp-conventions

plugins {
    id("build-logic.kotlin-multiplatform-conventions") // changed here
}

kotlin {
    js(IR) {
        nodejs {
        }
    }
}

[ragul-engg]

@robstoll I found out the issue. kotlin-js build logic was lacking the kotlin-conventions, adding that suppressed the warning.

[robstoll]

Sounds like I did something wrong, the Multiplattform convention should most likely be based on kotlin-convention as well. Would you like to check?

[ragul-engg]

looks like its just based on just gradle-conventions. should i change that to kotlin-conventions as it imports gradle-conventions anyway. I think it should be fine, what do you think?

[robstoll]

I think I missed to adjust it when I introduce kotlin-convention. Please change it, we will get a CI error if our assumption is wrong

[ragul-engg]

Done ✅, lets see whether our assumption is right

[robstoll]

Looks good 🙂👍

[robstoll]

Thanks for fixing more than required 🙂