Add comprehensive .dockerignore file #886
Conversation
Excludes development files, secrets, API keys, documentation, and common temporary files from Docker builds to reduce image size and prevent accidental inclusion of sensitive information.
|
Warning Rate limit exceeded@pavangudiwada has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 30 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Added comprehensive exclusions for: - Test reports and evaluation files - Additional Python build artifacts - Framework-specific files (Django, Flask, Scrapy) - Type checkers and debug symbols - Jupyter notebook files - Task scheduling files - Claude-specific trace files
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
.dockerignore (4)
51-57: Over-broad Markdown ignores hide important files and make later rules mootIgnoring all .md also ignores README, LICENSE, and changelogs and renders the CLAUDE.md rules below redundant. Prefer targeting docs directories or add allow-list exceptions.
Two options; pick one:
- Minimal: drop the broad patterns:
# Documentation docs/ docs/_build/ .sphinx-build/ -*.md -README* +# keep Markdown files (README, LICENSE, etc.) unless explicitly excluded
- Or keep most Markdown out but preserve key files:
-*.md -README* +*.md +!README* +!LICENSE* +!SECURITY.md +!CHANGELOG.md
120-121: Home-dir patterns aren’t supported; keep repo-local .holmes only“~/.holmes/” won’t match. The “.holmes/” rule below is sufficient.
Apply this diff:
-~/.holmes/ .holmes/
107-108: Remove redundant entries and duplicates
- .vscode/ and .idea/ already exclude their internal files (settings.json, workspace.xml).
- .DS_Store and *~ are already listed above.
Cleaning these up keeps the file readable.
Apply this diff:
-# Common mistakes -.vscode/settings.json -.idea/workspace.xml +# Common mistakes *.backup *.bak *.orig *.tmp -*~ -.DS_Store +*~Note: .DS_Store is already ignored earlier; the second occurrence is unnecessary.
Also applies to: 113-115
40-50: Optional: expand testing/dev caches coverageAdd a few common Python caches that are often missed.
Apply this diff:
# Testing .tox/ .coverage .coverage.* .cache nosetests.xml coverage.xml *.cover .hypothesis/ .pytest_cache/ +.mypy_cache/ +__pypackages__/ +.ruff_cache/Optional: also add
.python-versionunder the Python section if pyenv is used.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.dockerignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Pre-commit checks
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
🔇 Additional comments (3)
.dockerignore (3)
1-4: Solid baseline: VCS content excluded from build contextIgnoring .git (and .gitignore) meaningfully reduces context size and speeds up builds. Good call.
82-93: Secrets coverage looks good.env*, secrets/, credentials/, and key/cert extensions are well covered. Nice.
17-22: No first-party code under ignored directories
I’ve verified that none of the directorieslib/,lib64/,parts/, orvar/exist in the repository, so these.dockerignoreentries won’t exclude any first-party source. Feel free to merge.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
.gitignore (5)
1-7: Good OS junk filters; consider a few common additions (Windows/macOS).Nice catch including .DS_Store, ._*, Spotlight, Trashes, and Windows thumbs. You might also want to ignore these frequently-seen artifacts:
- Windows: Desktop.ini
- macOS: Icon?, .LSOverride, .AppleDouble, .TemporaryItems, .fseventsd, .VolumeIcon.icns
Apply this diff after Line 7:
+Desktop.ini +Icon? +.LSOverride +.AppleDouble +.TemporaryItems +.fseventsd +.VolumeIcon.icns
9-9: Scope temp/ to the repo root to avoid over-matching nested “temp” dirs.As written, temp/ will ignore any folder named temp anywhere in the tree, which may be broader than intended. If you only meant the top-level temp directory, anchor it.
-temp/ +/temp/
200-207: Backup/swap set looks good; add a couple of common editor patterns.Optional adds:
- Emacs lockfiles and backups: .#* and #*#
- “double extension” temp artifacts: .tmp.
*.backup *.bak *.orig *.tmp *~ *.swp *.swo +.#* +\#*\# +*.tmp.*
209-211: Redundant IDE entries; already covered by .vscode and .idea/.Since .vscode and .idea/ are ignored above, per-file entries here are redundant.
-.vscode/settings.json -.idea/workspace.xml
213-213: .env is great; consider consolidating env rules and add .envrc.*You already ignore .env and .env earlier; .env supersedes those. Consider consolidating to reduce duplication, and add direnv’s .envrc.
.env* +.envrcIf you consolidate, make sure any CI or tooling that expects committed env example files (e.g., .env.example) remains tracked by adding a negation like “!.env.example”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.dockerignore(1 hunks).gitignore(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .dockerignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
- GitHub Check: Pre-commit checks
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Results of HolmesGPT evals
Legend
|
1 participant
Excludes development files, secrets, API keys, documentation, and common temporary files from Docker builds to reduce image size and prevent accidental inclusion of sensitive information.
Also added some Git ignore paths