bug fix - krr period is 0, for period under 1 day

[arikalon1]

No description provided.

[coderabbitai]

Walkthrough

The change updates the logic for constructing the time period string in the load_pods method of the PrometheusMetricsService class. Now, periods up to one day are represented in hours (with an "h" suffix), and longer periods continue to use days (with a "d" suffix), both with upper bounds.

Changes

File(s)	Change Summary
robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py	Refined period string construction in load_pods to use hours for ≤1 day and days for >1 day.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch krr-under-day-duration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (2)

280-280: Consider adding explicit handling for zero-hour edge case.

While the current logic works, periods very close to zero could result in 0h which might still cause issues with Prometheus queries. Consider adding a minimum threshold:

-        hours_literal = min(int(period.total_seconds()) // 3600, 32)
+        hours_literal = min(max(int(period.total_seconds()) // 3600, 1), 32)

This ensures the minimum period is 1h even for very short durations.

---

283-283: Verify mathematical consistency in days calculation.

The days calculation uses // 3600 // 24 which is mathematically equivalent to // 86400, but less clear. For consistency and readability, consider:

-        days_literal = min(int(period.total_seconds()) // 3600 // 24, 32)
+        days_literal = min(int(period.total_seconds()) // 86400, 32)

This matches the constant used in the condition above and makes the calculation more explicit.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7119c and d5350ee.

📒 Files selected for processing (1)

• robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (1 hunks)

🔇 Additional comments (1)

robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (1)

278-284: Fix approved - logic correctly handles sub-day periods in hours.

The bug fix properly addresses the issue where periods under 1 day were being converted to 0 days. The new logic:

• Uses hours format ("Xh") for periods ≤ 1 day (86400 seconds)
• Uses days format ("Xd") for longer periods
• Properly caps both at 32 to prevent excessive query ranges

The mathematical calculations are correct and the implementation will resolve the original issue where sub-day periods resulted in invalid Prometheus queries.