-
Notifications
You must be signed in to change notification settings - Fork 283
add oci chart release for robusta #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdded GitHub Actions steps to authenticate with GitHub Container Registry and to package and push the Helm chart to an OCI registry (ghcr.io) during the release workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Runner as Workflow Runner
participant GHCR as GitHub Container Registry (ghcr.io)
participant HelmChart as Helm chart (repo/helm/robusta)
rect rgba(150, 200, 250, 0.12)
Note over GH,Runner: Release workflow starts
end
GH->>Runner: checkout + setup
GH->>Runner: run docker/login-action@v3 (login to ghcr.io)
Runner->>GHCR: authenticate (GITHUB_TOKEN)
GH->>Runner: helm package helm/robusta -> robusta-<RELEASE_VER>.tgz
Runner->>GHCR: helm push robusta-<RELEASE_VER>.tgz to oci://ghcr.io/.../charts
GHCR-->>Runner: accept/publish chart
GH->>GH: workflow completes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yaml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run_tests
🔇 Additional comments (2)
.github/workflows/release.yaml (2)
127-132: GitHub Container Registry login looks good.The GHCR login is correctly configured with the standard
docker/login-action@v3,ghcr.ioregistry, andGITHUB_TOKENfor authentication. The workflow permissions includepackages: write, which is appropriate.
134-137: All helm push configuration verified as correct.The three concerns have been confirmed:
The
helm pushsyntax for OCI registries in helm v3+ uses the formathelm push <archive>.tgz oci://<registry>/<repo>, which matches your code.Filename matching will work: Chart.yaml version is updated to
${{env.RELEASE_VER}}(lines 49, 51) beforehelm package helm/robustaexecutes, so the generated.tgzwill be namedrobusta-${{env.RELEASE_VER}}.tgzas expected.GHCR authentication is properly configured via the
docker/login-action@v3step (lines 127-132) with${{ secrets.GITHUB_TOKEN }}before the helm push command.The implementation is correct. Consider adding an explicit helm setup step if reproducibility across different runners is desired, but it's not required since helm is typically pre-installed on
ubuntu-latest.
closes #1801