Skip to content

Fix URL encoding of the last dot in kurarin (#665) #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x-sheep merged 1 commit into from
Mar 25, 2026
Merged

Fix URL encoding of the last dot in kurarin (#665) #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/variety/kurarin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@

decodeKurarin: function() {
var bd = this.board;
this.genericDecodeNumber16((bd.dots.length >> 1) | 1, function(idx, val) {
this.genericDecodeNumber16((bd.dots.length + 1) >> 1, function(idx, val) {
var dot = bd.dots[idx * 2];
var dot2 = bd.dots[idx * 2 + 1];
dot.setDot((val >> 2) & 3);
Expand All @@ -366,7 +366,7 @@

encodeKurarin: function() {
var bd = this.board;
this.genericEncodeNumber16((bd.dots.length >> 1) | 1, function(idx) {
this.genericEncodeNumber16((bd.dots.length + 1) >> 1, function(idx) {
var dot = bd.dots[idx * 2];
var dot2 = bd.dots[idx * 2 + 1];
var value = (dot.getDot() << 2) | (dot2 ? dot2.getDot() : 0);
Expand Down
30 changes: 30 additions & 0 deletions test/variety/kurarin_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
var assert = require("assert");
var pzpr = require("../../");

describe("Variety:kurarin", function() {
it("Check URL encoding of last two dots on the board", function() {
var puzzle = new pzpr.Puzzle();
puzzle.open("kurarin/5/6");

var dots = puzzle.board.dots;
var prevDot = dots[dots.length - 2];
var lastDot = dots[dots.length - 1];

// Set distinct values to the last two dots
// 1, 2, and 3 are valid states for a dot
prevDot.setDot(2);
lastDot.setDot(3);

var url = puzzle.getURL();

var puzzle2 = new pzpr.Puzzle();
puzzle2.open(url);

var dots2 = puzzle2.board.dots;
var prevDot2 = dots2[dots2.length - 2];
var lastDot2 = dots2[dots2.length - 1];

assert.equal(prevDot2.getDot(), 2);
assert.equal(lastDot2.getDot(), 3);
});
});
Loading