Open
Conversation
Anton-4
requested changes
Jan 6, 2025
Collaborator
Anton-4
left a comment
Anton-4
left a comment
There was a problem hiding this comment.
I had to wait on macos updates so I already did a partial review.
| name = "host" | ||
| version = "0.0.1" | ||
| authors = ["The Roc Contributors"] | ||
| license = "UPL-1.0" |
Collaborator
There was a problem hiding this comment.
The license should be changed to the license of this repo "CC0 1.0"
|
|
||
| type Op_StderrWrite = roc_std::RocStr; | ||
| type Op_StdoutWrite = roc_std::RocStr; | ||
| type TODO_roc_function_69 = roc_std::RocStr; |
Collaborator
There was a problem hiding this comment.
Should this TODO be changed before merging?
| discriminant_Op::Done => f.write_str("Done"), | ||
| discriminant_Op::StderrWrite => f | ||
| .debug_tuple("StderrWrite") | ||
| // TODO HAS CLOSURE |
Collaborator
There was a problem hiding this comment.
Should this TODO be handled before merging?
Collaborator
There was a problem hiding this comment.
Putting this comment here so I don't forget, tests still need to be added to ci_scripts/all_tests.sh
|
|
||
| Note: The JNI code depends on a dynamic lib, containing our native implementation, that now resides in our working directory.\ | ||
| So in the following examples, we'll make sure that our working directory is in LD_LIBRARY_PATH.\ | ||
| Generally speaking, you'd paobably add your dynamic library to a spot that's already on your path, for convenience sake.\ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.