Skip to content

Conversation

@runei
Copy link

@runei runei commented Jul 28, 2024

Implements #758

@github-actions github-actions bot added S-work-in-progress status: PR is still in progress and changing contrib PR not by a maintainer labels Jul 28, 2024
@runei
Copy link
Author

runei commented Aug 9, 2024

Hi @gavv ,

The libvorbis build is successful for all targets except macos14-arm64/build-3rdparty and macos14-arm64/universal-binaries. But it works fine with macos14-arm64/standard-build and other macos builds.

The error message is:

*** Could not run Ogg test program, checking why...
*** The test program failed to compile or link. See the file config.log for the
*** exact error that occurred. This usually means Ogg was incorrectly installed
*** or that you have moved Ogg since it was installed.
configure: error: must have Ogg installed!

But according to the logs, libogg was installed before this error.

What is the difference between the macos 3rdparty, universal-binaries, to the other macos standard-build?
Do you have any suggestion on how to solve this issue?

@gavv
Copy link
Member

gavv commented Sep 15, 2024

Hi @gavv ,

The libvorbis build is successful for all targets except macos14-arm64/build-3rdparty and macos14-arm64/universal-binaries. But it works fine with macos14-arm64/standard-build and other macos builds.

The error message is:

...

Most likely, configure from libvorbis is trying to find libogg using pkg-config instead of using paths that we gave to it. In this case we can prevent it by providing OGG_CFLAGS and OGG_LIBS variables to configure, the same way as we do it with LIBSNDFILE_ when we're building pulseaudio (also in build-3rdparty.py).

@github-actions github-actions bot added the S-needs-rebase status: PR has conflicts and should be rebased label Feb 11, 2025
@github-actions
Copy link

🤖 The latest upstream change made this pull request unmergeable. Please resolve the merge conflicts.

@gavv gavv added the S-stalled status: PR or issue is abandoned label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contrib PR not by a maintainer S-needs-rebase status: PR has conflicts and should be rebased S-stalled status: PR or issue is abandoned S-work-in-progress status: PR is still in progress and changing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants