feat: export astToZQL from @rocicorp/zero/ast-to-zql#5638
Open
jb-chief wants to merge 1 commit intorocicorp:mainfrom
Open
feat: export astToZQL from @rocicorp/zero/ast-to-zql#5638jb-chief wants to merge 1 commit intorocicorp:mainfrom
jb-chief wants to merge 1 commit intorocicorp:mainfrom
Conversation
Add `./ast-to-zql` to the package exports map so consumers can import the AST-to-ZQL serializer without resorting to dynamic import hacks. This enables use cases like query plan regression testing where you extract the AST from a query builder and serialize it back to a ZQL string for analyze-query.
|
@jb-chief is attempting to deploy a commit to the Rocicorp Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds
./ast-to-zqlto the@rocicorp/zeropackageexportsmap so consumers can import theastToZQLfunction directly:Motivation
We're building query plan regression tests that:
.astgetterastToZQLanalyze-query --queryto verify no table scans, proper index usage, etc.This keeps our tests automatically in sync with our real query definitions — if a query changes, the test reflects it without manual string updates.
Currently we have to use a dynamic import hack to access the function since it's not in the
exportsmap:Change
One-liner addition to
packages/zero/package.jsonexports, following the existing{ types, default }pattern:No new code — just exposing an existing internal module.