chore(analyze-query): use shared runAst from zero-cache instead of local copy#5669
Open
chore(analyze-query): use shared runAst from zero-cache instead of local copy#5669
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…l copy Remove duplicated run-ast.ts from analyze-query and import the canonical implementation from zero-cache. Update call sites to match the new function signature (auth object, async callback).
|
Bencher Report| Branch | mlaw/aq-cli |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 1,922.85 KB(-0.07%)Baseline: 1,924.12 KB | 1,962.61 KB (97.97%) |
| zero.js | 📈 view plot 🚷 view threshold | 278.62 KB(0.00%)Baseline: 278.62 KB | 284.20 KB (98.04%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 73.97 KB(0.00%)Baseline: 73.97 KB | 75.45 KB (98.04%) |
|
| Branch | mlaw/aq-cli |
| Testbed | self-hosted |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🚨 27 Alerts
🐰 View full continuous benchmarking report in Bencher
|
| Branch | mlaw/aq-cli |
| Testbed | self-hosted |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| src/client/custom.bench.ts > big schema | Throughput operations / second (ops/s) x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 109.47 ops/s x 1e3(-15.37%)Baseline: 129.35 ops/s x 1e3 | 114.54 ops/s x 1e3 (104.64%) |
| src/client/zero.bench.ts > pk compare > pk = N | Throughput operations / second (ops/s) x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 48.92 ops/s x 1e3(-15.93%)Baseline: 58.19 ops/s x 1e3 | 54.57 ops/s x 1e3 (111.55%) |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) x 1e3 (Result Δ%) | Lower Boundary operations / second (ops/s) x 1e3 (Limit %) |
|---|---|---|---|
| src/client/custom.bench.ts > big schema | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 109.47 ops/s x 1e3(-15.37%)Baseline: 129.35 ops/s x 1e3 | 114.54 ops/s x 1e3 (104.64%) |
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 1.98 ops/s x 1e3(-5.01%)Baseline: 2.09 ops/s x 1e3 | 1.16 ops/s x 1e3 (58.69%) |
| src/client/zero.bench.ts > pk compare > pk = N | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 48.92 ops/s x 1e3(-15.93%)Baseline: 58.19 ops/s x 1e3 | 54.57 ops/s x 1e3 (111.55%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 3.01 ops/s x 1e3(-9.40%)Baseline: 3.32 ops/s x 1e3 | 2.42 ops/s x 1e3 (80.45%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the analyze-query CLI so we can continue doing targeted analysis without swamping zero-cache by loading the related application.
Sometimes loading an app kills zero-cache so you can't get much query analysis done without making a bunch of changes to the app (e.g., terabugs).
Remove duplicated run-ast.ts from analyze-query and import the canonical implementation from zero-cache. Update call sites to match the new function signature (auth object, async callback).