fix(zqlite): skip IS NULL in cursor queries for non-nullable columns#5673
Open
utkarsh-611 wants to merge 1 commit intorocicorp:mainfrom
Open
fix(zqlite): skip IS NULL in cursor queries for non-nullable columns#5673utkarsh-611 wants to merge 1 commit intorocicorp:mainfrom
utkarsh-611 wants to merge 1 commit intorocicorp:mainfrom
Conversation
|
@utkarsh-611 is attempting to deploy a commit to the Rocicorp Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor pagination queries generate IS NULL checks for non-nullable columns, causing SQLite to abandon its MULTI-INDEX OR optimization and fall back to full table scans.
This is the cursor-pagination counterpart to the getRows fix in #5542 — same SQLite NULL+OR issue, different code path (gatherStartConstraints in query-builder.ts).
Fix: check columnTypes[field].optional and skip IS NULL branches for non-nullable columns.