Skip to content

fix(quarto-cli): use quarto install instead of quarto tools install#252

Merged
eitsupi merged 8 commits intorocker-org:mainfrom
juliopterix:patch-1
May 23, 2025
Merged

fix(quarto-cli): use quarto install instead of quarto tools install#252
eitsupi merged 8 commits intorocker-org:mainfrom
juliopterix:patch-1

Conversation

@juliopterix
Copy link
Contributor

quarto tools has been superseded. only use quarto install

`quarto tools` has been superseded. only use `quarto install`
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
If I understand correctly, quarto tools install still works, and I believe that in past versions, quarto install did not work and only quarto tools install did.
So I am not sure if it is worth replacing quarto tools install with quarto install.

@juliopterix
Copy link
Contributor Author

true; apparently tools has been depricated in 2022: quarto-dev/quarto-cli#1437 (comment)
Which might be fine then, but it's up to you do decide.
quarto tools install only throws a warning for now, so it's just a nice to have.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

After checking the documentation (NOTES.md) and tests, it seems that quarto tools install also only works after 1.2 in the first place, and the replacement does not seem to affect the release version since it still passes the test for 1.2 after the change to quarto install.

"tinytex": {
"image": "debian:stable-slim",
"features": {
"quarto-cli": {
"version": "1.2",
"installTinyTex": true
}
}
},

So there seems to be no problem updating it.

If you could make the following modifications, I believe we can merge this.

  • Update the document
  • Bump patch version of this Feature

@eitsupi eitsupi changed the title Update install.sh fix(quarto-cli): use quarto install instead of quarto tools install May 21, 2025
@juliopterix
Copy link
Contributor Author

Thanks for looking into this!
I tried to follow what you requested.
If this was not all what you meant, could you please clarify (esp. 'bump patch version')?
Thank you!

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you edit the following locations to increment the patch version.

@eitsupi
Copy link
Member

eitsupi commented May 22, 2025

I've updated some tests.
It would be appreciated if you could merge the main branch and confirm that it passes the tests.

@juliopterix
Copy link
Contributor Author

Hi, thank you very much for the additional tests and effort!
I ran the tests and they passed.
I will run them again so that you can see the results when you find the time.

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you update these descriptions?

"installTinyTex": {
"type": "boolean",
"default": false,
"description": "Install TinyTeX by using the `quarto tools install tinytex` command. Works only with version 1.2 or later."
},
"installChromium": {
"type": "boolean",
"default": false,
"description": "Run the `quarto tools install chromium` command. Check the document for details."
}

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eitsupi eitsupi merged commit 6ca6f4f into rocker-org:main May 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants