fix(quarto-cli): use quarto install instead of quarto tools install#252
fix(quarto-cli): use quarto install instead of quarto tools install#252eitsupi merged 8 commits intorocker-org:mainfrom
quarto install instead of quarto tools install#252Conversation
`quarto tools` has been superseded. only use `quarto install`
eitsupi
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
If I understand correctly, quarto tools install still works, and I believe that in past versions, quarto install did not work and only quarto tools install did.
So I am not sure if it is worth replacing quarto tools install with quarto install.
|
true; apparently |
There was a problem hiding this comment.
Thanks for clarifying!
After checking the documentation (NOTES.md) and tests, it seems that quarto tools install also only works after 1.2 in the first place, and the replacement does not seem to affect the release version since it still passes the test for 1.2 after the change to quarto install.
devcontainer-features/test/quarto-cli/scenarios.json
Lines 2 to 10 in 8c89888
So there seems to be no problem updating it.
If you could make the following modifications, I believe we can merge this.
- Update the document
- Bump patch version of this Feature
quarto install instead of quarto tools install
|
Thanks for looking into this! |
eitsupi
left a comment
There was a problem hiding this comment.
Could you edit the following locations to increment the patch version.
|
I've updated some tests. |
|
Hi, thank you very much for the additional tests and effort! |
eitsupi
left a comment
There was a problem hiding this comment.
Thanks, could you update these descriptions?
devcontainer-features/src/quarto-cli/devcontainer-feature.json
Lines 17 to 26 in 75c2915
quarto toolshas been superseded. only usequarto install