ci: build core images on native runners - #1030
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves core image publishing to native architecture runners with digest-based multi-registry manifests.
Changes:
- Adds reusable per-target native build and publication workflow.
- Adds digest validation, manifest finalization, and smoke testing.
- Documents and tests the new publishing flow.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/core.yml |
Orchestrates target builds and smoke tests. |
.github/workflows/core-target.yml |
Builds platforms and publishes manifests. |
.github/workflows/bakefile-test.yml |
Expands CI test triggers. |
build/scripts/core-publish.sh |
Implements publication and verification. |
build/scripts/test-core-publish.sh |
Tests publication metadata handling. |
build/scripts/test-core-workflow.sh |
Validates workflow/Bake alignment. |
Makefile |
Adds new test targets. |
build/README.md |
Documents core publishing. |
bakefiles/README.md |
Clarifies Bake file responsibilities. |
Suppressed comments (1)
.github/workflows/core-target.yml:78
- Each repeated
output=override replaces the previous Bake value, so the GHCR line wins and the canonical digest is never pushed to Docker Hub.write-metadatanevertheless records that digest for both registries, causingfinalizeto fail when it inspectsdocker.io/...@digest. Append the second exporter instead of replacing the first.
${{ inputs.target }}.output=type=image,name=${{ steps.config.outputs.docker_repository }},push-by-digest=true,name-canonical=true,push=true
${{ inputs.target }}.output=type=image,name=${{ steps.config.outputs.ghcr_repository }},push-by-digest=true,name-canonical=true,push=true
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/workflows/core.yml:23
cancel-in-progress: falseprotects only the running workflow; withoutqueue: max, GitHub keeps only one pending run and cancels that pending run when a third run joins this group. Because push, release, and manual publishers all share this group, an all-version release publish can be dropped behind a later latest-only run. Addqueue: maxand update the concurrency assertion intest-core-workflow.shso publisher runs are actually queued rather than replaced.
group: core-publish
cancel-in-progress: false
build/scripts/test-core-workflow.sh:32
- This alternation accepts
needs: preparefor every target, so the test still passes if any post-r-verjob loses its dependency on the preceding target. Compute the one expectedneedsvalue for each iteration and compare it exactly so the serialization regression this test is intended to catch cannot slip through.
grep -Eq "needs: (prepare|\[prepare, ${previous}\])$" <<<"${block}" || {
eitsupi
marked this pull request as ready for review
August 16, 2026 07:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #901
Related to #1015
Created by Codex gpt-5.6-sol