Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables P3M binary R package installation support for arm64 platform by removing architecture-specific source installation requirements and adding arm64 platform support to build configurations.
- Removes forced source compilation for arm64 architecture in R setup script
- Adds linux/arm64 platform support to Docker build configurations
- Updates CI workflows to build and test on arm64 runners
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/setup_R.sh | Removes arm64-specific source installation logic to enable binary packages |
| build/templates/bakefiles/main.docker-bake.json | Adds arm64 platform to build template |
| bakefiles/4.5.1.docker-bake.json | Adds arm64 platform to R 4.5.1 build |
| bakefiles/4.5.0.docker-bake.json | Adds arm64 platform to R 4.5.0 build |
| .github/workflows/r-build-test.yml | Updates CI to use arm64 runners and test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #830