-
-
Notifications
You must be signed in to change notification settings - Fork 18
Refactor data access layer to use shared enums and interfaces #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a4b6289
4edcb8d
e87eb23
f6b3f81
b0ccd25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,13 +3,13 @@ import { HttpException } from '@nestjs/common/exceptions/http.exception.js'; | |||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | ||||||
|
||||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | |
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/shared/enums/connection-types-enum.js'; |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| import { ConnectionEntity } from '../entities/connection/connection.entity.js'; | ||||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | ||||||
|
||||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | |
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/shared/enums/connection-types-enum.js'; |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,6 @@ import { CreateTableWidgetDto } from '../src/entities/widget/dto/index.js'; | |||||
| import { AccessLevelEnum, PermissionTypeEnum, QueryOrderingEnum, WidgetTypeEnum } from '../src/enums/index.js'; | ||||||
| import { TestConstants } from './mocks/test-constants.js'; | ||||||
| import json5 from 'json5'; | ||||||
| import { ConnectionTypeTestEnum } from '../src/enums/connection-type.enum.js'; | ||||||
| import { CreateConnectionDto } from '../src/entities/connection/application/dto/create-connection.dto.js'; | ||||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | ||||||
|
||||||
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.js'; | |
| import { ConnectionTypesEnum } from '@rocketadmin/shared-code/dist/src/shared/enums/connection-types-enum.js'; |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import path is incorrect after the refactoring. The
ConnectionTypesEnumhas been moved from@rocketadmin/shared-code/dist/src/data-access-layer/shared/enums/connection-types-enum.jsto@rocketadmin/shared-code/dist/src/shared/enums/connection-types-enum.js. This will cause a compilation error since the old file is being deleted.Update the import to: