Skip to content

Conversation

@Artuomka
Copy link
Collaborator

@Artuomka Artuomka commented Dec 9, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 9, 2025 09:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a conditional check that filters out Redis keys with type 'none' in the getTablesFromDB() method. The change comments out the validation that prevented non-existent keys from being added to the standalone keys array.

Key Changes:

  • Commented out the if (keyType !== 'none') condition check
  • All keys returned by redisClient.type() will now be pushed to standaloneKeys, including those with type 'none'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +829 to +831
// if (keyType !== 'none') {
standaloneKeys.push({ key, type: keyType });
// }
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this check will cause non-existent keys to be included in the results. In Redis, the TYPE command returns 'none' when a key doesn't exist. This can happen due to a race condition: a key could be deleted between the keys('*') call on line 818 and the type(key) call on line 828. Without this check, tables with names like [none]deleted_key would be created for keys that no longer exist, which would lead to incorrect table listings.

Suggested change
// if (keyType !== 'none') {
standaloneKeys.push({ key, type: keyType });
// }
if (keyType !== 'none') {
standaloneKeys.push({ key, type: keyType });
}

Copilot uses AI. Check for mistakes.
@Artuomka Artuomka merged commit 0acddd7 into main Dec 9, 2025
22 checks passed
@Artuomka Artuomka deleted the backend_redis_fixes branch December 9, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants