Skip to content

feat: add devcontainer configuration and proxy setup for API requests #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gugu merged 3 commits into from
Dec 16, 2025
+31 −1
Merged

feat: add devcontainer configuration and proxy setup for API requests #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e9ebef
feat: add devcontainer configuration and proxy setup for API requests
lyubov-voloshko Dec 15, 2025
1988798
Merge branch 'main' into dev-container
gugu Dec 16, 2025
81fe5cc
Merge branch 'main' into dev-container
gugu Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
"name": "Node.js & TypeScript",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-22-bookworm"

// Features to add to the dev container. More info: https://containers.dev/features.
// "features": {},

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "yarn install",

// Configure tool-specific properties.
// "customizations": {},

// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "root"
}
4 changes: 3 additions & 1 deletion frontend/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"buildTarget": "dissendium-v0:build"
"buildTarget": "dissendium-v0:build",
"host": "127.0.0.1",
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding the development server to "127.0.0.1" may prevent access from outside the container in a devcontainer environment. For devcontainer usage, consider using "0.0.0.0" as the host to allow connections from the host machine, or omit the host configuration to use Angular's default behavior.

Suggested change
"host": "127.0.0.1",
"host": "0.0.0.0",

Copilot uses AI. Check for mistakes.
"proxyConfig": "src/proxy.conf.json"
},
"configurations": {
"production": {
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/proxy.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"/api/**": {
"target": "https://app.rocketadmin.com/api/",
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proxy target URL appears to have a double path issue. The target is set to "https://app.rocketadmin.com/api/" but the context is "/api/**". This means requests to "/api/endpoint" will be proxied to "https://app.rocketadmin.com/api/api/endpoint" with a duplicated "/api" path segment. The target should likely be "https://app.rocketadmin.com" without the "/api/" suffix.

Suggested change
"target": "https://app.rocketadmin.com/api/",
"target": "https://app.rocketadmin.com",

Copilot uses AI. Check for mistakes.
"secure": false
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting "secure" to false disables SSL certificate verification, which can expose the application to man-in-the-middle attacks. Unless there's a specific reason for this (e.g., self-signed certificates in development), this should be set to true for security best practices, especially when connecting to a production API endpoint.

Suggested change
"secure": false
"secure": true

Copilot uses AI. Check for mistakes.
}
}
Loading