Skip to content

Remove balance queries from v10 #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jshufro wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove balance queries from v10 #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fe9db
Remove balance queries from v10
jshufro Nov 21, 2024
4d5bf8a
Remove toothless sentence about negative income
jshufro Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/rpip-62/rewards-calculation-spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,10 +630,10 @@ For each slot in the reward interval, get the list of validator withdrawals (e.g
```go
minipoolWithdrawals[address] += amount
```
Then, get `startBcBalance` and `endBcBalance` for each minipool by querying for validator balances at `rewardStartBcSlot` and `rewardEndBcSlot`, respectively (e.g. `/eth/v1/beacon/states/<slotIndex>/validator_balances`). Use them to calculate the minipool's eligible consensus income and corresponding bonus. In case of negative consensus income, award no bonus.
Calculate the minipool's eligible consensus income and corresponding bonus.
```go
bonusFee := getTotalFee(rewardBaseFee, percentOfBorrowedETH) - rewardBaseFee
consensusIncome := endBcBalance + minipoolWithdrawals[minipool.Address] - max(32 Eth, startBcBalance)
consensusIncome := minipoolWithdrawals[minipool.Address]
bonusShare := bonusFee * (32 Eth - rewardBond) / 32 Eth
result := max(0, consensusIncome * bonusShare / 1 Eth)
```
Expand Down Expand Up @@ -671,4 +671,4 @@ poolStakerEth := smoothingPoolBalance - totalEthForMinipools

## Constructing the Tree

With all of the above values, you can now create the Merkle tree for this interval using the [tree specification](../rpip-53/merkle-tree-spec.md).
With all of the above values, you can now create the Merkle tree for this interval using the [tree specification](../rpip-53/merkle-tree-spec.md).