-
Notifications
You must be signed in to change notification settings - Fork 155
Add go.work, go.work.sum, and turn smartnode top level packages into modules #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshufro
commented
May 7, 2025
597d853 to
c1c0369
Compare
0xfornax
reviewed
May 19, 2025
0xfornax
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last piece in removing smartnode-install: porting the build to this repository.
The
make releasecommand builds all artifacts for a release, creates and tags docker containers, and creates and tags a docker manifest. I have not addeddocker pushcommands, as I think those should be executed cautiously, but we can add them if we want.make releasecurrently will make a directory structure a la:but we can flatten it to behave more like smartnode-install if we want. This just feels more organized.