basics-scissors-paper-stone-submission-homingquan#361
Open
KenHo95 wants to merge 3 commits intorocketacademy:mainfrom
Open
basics-scissors-paper-stone-submission-homingquan#361KenHo95 wants to merge 3 commits intorocketacademy:mainfrom
KenHo95 wants to merge 3 commits intorocketacademy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
8 hours
Please fill in one error and/or error message you received while working on this assignment.
"Uncaught ReferenceError: playerWinRecord is not defined"
What part of the assignment did you spend the most time on?
Implementing the reverse functionality of the game
Comfort Level (1-5):
5
Completeness Level (1-5):
4
What did you think of this deliverable?
Fun. Learnt the basic JavaScripts syntax. Understood states control flow at a better level. Tried to implement best practices as well.
Is there anything in this code that you feel pleased about?
Adding funny messages to the output based on player's score
What's one aspect of your code you would like specific, elaborate feedback on?
Parts of the code that could implement best practice on (i.e. refactoring)