Open
Conversation
DominiqueYeo
left a comment
DominiqueYeo
left a comment
There was a problem hiding this comment.
Nice helper functions making the main code short and clean. Interesting way of determining the reversed game!
Comment on lines
+1
to
+8
| // Counters to keep track of scores | ||
| var totalAttempts = 0; | ||
| var userWinCount = 0; | ||
| var computerWinCount = 0; | ||
| var drawCount = 0; | ||
| // Player's name | ||
| var userName = ""; | ||
| var emptyUserName = true; |
There was a problem hiding this comment.
good commenting to explain the variables
| var userInputForGame = userInput; | ||
| var userWon = true; | ||
| if (userInput.startsWith("Reversed")) { | ||
| userInputForGame = userInputForGame.replace("Reversed ", ""); |
There was a problem hiding this comment.
nice use of string method to format your user input for the reversed game
Comment on lines
+77
to
+79
| if (reversedGame == true) { | ||
| userWon = !userWon; | ||
| } |
There was a problem hiding this comment.
Interesting way of handling the reversed game logic!
Comment on lines
+104
to
+111
| // if ("win" in battleResult) { | ||
| // userWinCount += 1; | ||
| // } else if ("lose" in battleResult) { | ||
| // computerWinCount += 1; | ||
| // } else { | ||
| // drawCount += 1; | ||
| // } | ||
|
|
There was a problem hiding this comment.
can remove unused code before sharing code for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
Comfort Level (1-5):
Completeness Level (1-5):
What did you think of this deliverable?
Is there anything in this code that you feel pleased about?