Open
Conversation
michelle-mok
left a comment
michelle-mok
left a comment
There was a problem hiding this comment.
good work on providing lots of comments that make your code easier to read!
also good work on organising your code into functions!
consider splitting your code up into different files so that it is tidier
keep up the good work!
Comment on lines
+604
to
+621
| // Total points and bid points ------------------------------------------- | ||
| // initialize bidPointsHeadingEl functionality | ||
| bidPointsHeadingEl.innerText = 'Points Bidded'; | ||
| bidPointsContainer.appendChild(bidPointsHeadingEl); | ||
| // initialize bidPointsInfoEl functionality | ||
| bidPointsInfoEl.innerText = playerBidPoints; | ||
| bidPointsContainer.appendChild(bidPointsInfoEl); | ||
| // initialize bidPointsContainer functionality | ||
| gameDisplayContainer.appendChild(bidPointsContainer); | ||
| // initialize totalPointsHeadingEl functionality | ||
| totalPointsHeadingEl.innerText = 'Total Points'; | ||
| totalPointsContainer.appendChild(totalPointsHeadingEl); | ||
| totalPointsContainer.appendChild(totalPointsHeadingEl); | ||
| // initialize totalPointsInfoEl functionality | ||
| totalPointsInfoEl.innerText = playerTotalPoints; | ||
| totalPointsContainer.appendChild(totalPointsInfoEl); | ||
| // initialize totalPointsContainer functionality | ||
| gameDisplayContainer.appendChild(totalPointsContainer); No newline at end of file |
There was a problem hiding this comment.
consider putting this block of code into a function, and calling the function in initGame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
Comfort Level (1-5):
Completeness Level (1-5):
What did you think of this deliverable?
Is there anything in this code that you feel pleased about?