Skip to content

Ivan PTBC2-1#33

Open
gysiang wants to merge 27 commits intorocketacademy:mainfrom
gysiang:master
Open

Ivan PTBC2-1#33
gysiang wants to merge 27 commits intorocketacademy:mainfrom
gysiang:master

Conversation

@gysiang
Copy link

@gysiang gysiang commented Dec 16, 2021

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?
1 week

Please fill in one error and/or error message you received while working on this assignment.
card did not load correctly

What part of the assignment did you spend the most time on?
doing the design of the page

Comfort Level (1-5):
4

Completeness Level (1-5):
4

What did you think of this deliverable?
Challenging.

Is there anything in this code that you feel pleased about?

@upieez
Copy link

upieez commented Jan 7, 2022

What went well

  • Refactoring your game logic into different files for better separation of concerns
  • Great use of images and audio for your game
  • Clearly defined variable names and good use of JSDocs
  • Consistent and clean visual design
  • Good and frequent use of Git

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider making your game mobile responsive
  • Consider adding some visual indicator for your game
    • Bets can only be placed once
    • Disallowing user to click on Deal/Swap before they place a bet
    • Disallowing user to click on Bet after they have placed a bet
    • Having highly contrasting colours for your text on the buttons
  • Consider removing unused files (i.e script.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants