Skip to content

Felicia - PTBC2-1#34

Open
sundriedtomato12 wants to merge 11 commits intorocketacademy:mainfrom
sundriedtomato12:master
Open

Felicia - PTBC2-1#34
sundriedtomato12 wants to merge 11 commits intorocketacademy:mainfrom
sundriedtomato12:master

Conversation

@sundriedtomato12
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?
Many

Please fill in one error and/or error message you received while working on this assignment.
Had some issues trying to figure out how to select cards to redraw and actually redraw them. But eventually figured it out using an array to store the indexes of the selected cards.

What part of the assignment did you spend the most time on?
Quite evenly spread throughout.

Comfort Level (1-5):
3

Completeness Level (1-5):
3.5?

What did you think of this deliverable?
Thought this was really challenging, but really fun too :)

Is there anything in this code that you feel pleased about?
Really amazed that I was able to complete this at only week 5 of the Bootcamp course even though it doesn't look very fancy ^_^

@upieez
Copy link

upieez commented Jan 7, 2022

What went well

  • Game's design is clean and has a nostalgic theme to it
    • Ties in well with the use of audio and image gif
  • Good job on using CSS flex property to make it mobile responsive
    • Nice use of CSS selectors too
  • Nice work on separating your code into different files so that it's easier
  • Good use of meaningful Git commit when you have made changes

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider adding a bit more colour or better visual cue (bigger font size) for your output message
  • Consider having an alternative when a user runs out of credit
  • Consider making your functions smaller and more modular
  • Consider removing comments that are self-explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants