Skip to content

Kenneth PTBC 2#35

Open
kennethongcs wants to merge 54 commits intorocketacademy:mainfrom
kennethongcs:master
Open

Kenneth PTBC 2#35
kennethongcs wants to merge 54 commits intorocketacademy:mainfrom
kennethongcs:master

Conversation

@kennethongcs
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?

10
Please fill in one error and/or error message you received while working on this assignment.

What part of the assignment did you spend the most time on?
Logic
Comfort Level (1-5):
3
Completeness Level (1-5):
3
What did you think of this deliverable?
Helped me apply my knowledge and helped to apply what was taught in lessons.
Is there anything in this code that you feel pleased about?
Logic

@upieez
Copy link

upieez commented Jan 10, 2022

What went well

  • Good use of visual indicators to let users know of the actions that they can take
  • Game is mobile responsive and can be played on both the desktop and mobile
  • Meaningful and frequent Git commits
  • Refactored code into different files for better separation of concerns
  • CSS classnames and JS functions/variables names are clear

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider using less muted colours for your game
  • Consider shrinking down the font for your betting table when viewed in mobile
  • Consider testing your game by playing through till the end a couple of times to iron out some game breaking bugs
  • Consider using/adding some images, audio or even a different font style to your game
  • Consider removing commented out code that isn't part of the game
  • Consider refactoring some functions to be smaller and more modular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants