Skip to content

YanXiang - PTBC2-1#36

Open
Nyx92 wants to merge 10 commits intorocketacademy:mainfrom
Nyx92:master
Open

YanXiang - PTBC2-1#36
Nyx92 wants to merge 10 commits intorocketacademy:mainfrom
Nyx92:master

Conversation

@Nyx92
Copy link

@Nyx92 Nyx92 commented Dec 20, 2021

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment? Days.

Please fill in one error and/or error message you received while working on this assignment.

What part of the assignment did you spend the most time on? Everything brother.

Comfort Level (1-5): 4

Completeness Level (1-5): 4

What did you think of this deliverable? Challenging

Is there anything in this code that you feel pleased about? Very pleased I didn't refer to anyone else's code. My js file is in a huge mess though...

@upieez
Copy link

upieez commented Jan 7, 2022

What went well

  • Consistent design theme in your game
  • Good use of images for your cards
  • Using a third party font so that it sits well with your design
  • Great use of table to display the credit amount won depending on the hand
  • Good visual indicator to show the bet amount in the tab

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider reducing the amount of CSS animation as it slows down the game considerably
  • Consider committing your code with more meaningful git messages
  • Consider refactoring your game logic to different files so that it's easier to read your code
  • Consider removing comments so as to declutter your code to enhance readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants