Edwin | PTBC2-1

[edwinyxt]

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?

Please fill in one error and/or error message you received while working on this assignment.

What part of the assignment did you spend the most time on?

Comfort Level (1-5): 4

Completeness Level (1-5): 4

What did you think of this deliverable? Great practice of CSS

Is there anything in this code that you feel pleased about? Developed probability logic

[upieez]

What went well

• Clean and visually appealing design
  • Great use of complementing colors
• Good use of visual indicators to let users know of the action that they can take
  • Betting table to let user know of the payout mulitplier
  • Letting user know whether the card selected is to keep or swap
  • Disabling buttons to direct users through the game flow
• Great additional features such as calculating the probability and advise me which gives users more ways to play your game
• Great use of third party resources such as the card design, audio and a different font style
• Code is kept organised
  • Clear variable/function names and CSS class names
  • No unnecessary comments
  • Functions are small and modular

What can be improved

• Consider making your game playable for mobile view
• Consider an alternative when the player runs out of credit
• Consider committing having more descriptive commit messages
• Consider creating different folders to keep your repository organised:
  • an asset folder to keep your images
  • a style folder to keep your CSS
  • a script folder to keep your JS
• Consider refactoring your code into different JS files for better separation of concern and better readability
• Consider keeping global variables at the top of the file