Skip to content

Therese | PTBC 2-1#45

Open
thereseLYR wants to merge 9 commits intorocketacademy:mainfrom
thereseLYR:master
Open

Therese | PTBC 2-1#45
thereseLYR wants to merge 9 commits intorocketacademy:mainfrom
thereseLYR:master

Conversation

@thereseLYR
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?
10-15h, give or take

Please fill in one error and/or error message you received while working on this assignment

What part of the assignment did you spend the most time on?
scoring logic

Comfort Level (1-5):
4

Completeness Level (1-5):
4

What did you think of this deliverable?
good blend of challenges in both gameplay implementation (scoring) and front-end design with CSS

Is there anything in this code that you feel pleased about?
confetti :>

@upieez
Copy link

upieez commented Jan 8, 2022

What went well

  • Meaningful commit messages
  • Clean design theme and having minimal colours
  • Good use of images for your cards
  • Good use of visual indicators to let users know of the action that they can take
    • Cards and button have a hover effect
    • Card back flipped when selecting the card to swap
    • Buttons disabled during certain mode (betting, swapping and end game)
    • Game over screen
  • Separating your code into different files for better readability
  • Good use of JSDocs and clear name for your functions/variables

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, etc...)
  • Consider making your game mobile responsive, allowing users to play on both the desktop and on a smaller device
  • Consider reducing the amount of white space/padding between the users action (clicking of cards, betting of points and clicking of deal/play)
  • Consider adding some validation when a user enters a number greater than the points remaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants