Skip to content

Shazwi | PTBC 2-1#47

Open
supershazwi wants to merge 26 commits intorocketacademy:mainfrom
supershazwi:master
Open

Shazwi | PTBC 2-1#47
supershazwi wants to merge 26 commits intorocketacademy:mainfrom
supershazwi:master

Conversation

@supershazwi
Copy link

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?

  • 2 weeks.

Please fill in one error and/or error message you received while working on this assignment.

  • Constantly mixing up the ranks when dealing with looping through objects.

What part of the assignment did you spend the most time on?

  • Probability

Comfort Level (1-5):

  • 3

Completeness Level (1-5):

  • 3

What did you think of this deliverable?

  • Complex to think about the probability section.

Is there anything in this code that you feel pleased about?

  • To get a basic working product out.

@upieez
Copy link

upieez commented Jan 7, 2022

What went well

  • Great clean and consistent design for your game
    • Good use of third party resources
    • Using of table for betting information with table highlighted with respect to their bet
    • Visual indicator for letting the user know what they can/cannot click
  • Separation of concerns for your game logic
  • Clear variable and function names
  • Functions are small and modular

What can be improved

  • Consider updating your README.md to document what your app does (i.e images of your game, further ideas of future features, resources you have used, what features your game has, a link to your game, etc...)
  • Consider writing meaningful message for your commits
  • Consider adding audio/animation to engage the user
  • Consider making it more mobile friendly
  • Consider removing comments that have a self-explaining function name

Suggestion for probability section

Often times when we are creating a feature, we look at the bigger picture and might feel overwhelmed with how complex and big it might be. You can consider looking at a small part of the probability feature, perhaps just calculating one swapped card first. Once you have nailed it down and feel satisfied with it, you can work on calculating two swapped cards. You might be surprised how the difficulty decreases as you progress with the feature. Remember, you don't have to get everything out immediately - sometimes having one good part of the feature is better than having one poor big feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants