Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
Over 3 days, 12 hours total.
Please fill in one error and/or error message you received while working on this assignment.
Logical errors in CSS alignment of elements.
What part of the assignment did you spend the most time on?
The design of the UI, trying to align every element to fit nicely in a desktop app.
Comfort Level (1-5):
5
Completeness Level (1-5):
4
What did you think of this deliverable?
I think it turned out as expected and I am satisfied with how it turned out, however I feel more can be done with the design of the UI if I had more experience in UI/UX.
Is there anything in this code that you feel pleased about?
Pleased that I was able to figure out the calcHandScore function and other logic across the functions, and the other DOM manipulation components, such that I did not have to touch the HTML body.