Change to gql macro and add a new macro#1
Merged
rockneurotiko merged 11 commits intomainfrom Aug 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GraphQL query validation library by adding new macros for handling dynamic queries and improving error reporting. The main change is replacing the deprecated Apollo compiler parser with the newer direct Document parsing API, while introducing structured error handling and expanding macro capabilities.
Key changes:
- Replace deprecated Apollo compiler parser with Document::parse API
- Introduce structured error types (ValidationError, Location) with proper JSON error handling
- Add new
gqlandgql_from_filemacros for dynamic query handling with compile-time expansion - Enhance formatter to handle dynamic parts detection
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| native/graphql_query_native/src/lib.rs | Replace deprecated parser API, add structured error types, and implement JSON error formatting |
| lib/graphql_query/validator.ex | Extract validation logic into dedicated module |
| lib/graphql_query/parser.ex | Add utility functions for dynamic parts detection and error formatting |
| lib/graphql_query/native.ex | Add structured error type definitions and update NIF error handling |
| lib/graphql_query/formatter.ex | Enhance formatter to skip dynamic queries |
| lib/graphql_query/format.ex | Extract formatting logic into separate module |
| lib/graphql_query.ex | Major refactor adding gql and gql_from_file macros with dynamic expansion capabilities |
| README.md | Update documentation with new macro usage examples and features |
| .formatter.exs | Add formatter configuration for new macros |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.