Skip to content

Change to gql macro and add a new macro#1

Merged
rockneurotiko merged 11 commits intomainfrom
change_to_macro
Aug 15, 2025
Merged

Change to gql macro and add a new macro#1
rockneurotiko merged 11 commits intomainfrom
change_to_macro

Conversation

@rockneurotiko
Copy link
Owner

No description provided.

@rockneurotiko rockneurotiko requested a review from Copilot August 14, 2025 19:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GraphQL query validation library by adding new macros for handling dynamic queries and improving error reporting. The main change is replacing the deprecated Apollo compiler parser with the newer direct Document parsing API, while introducing structured error handling and expanding macro capabilities.

Key changes:

  • Replace deprecated Apollo compiler parser with Document::parse API
  • Introduce structured error types (ValidationError, Location) with proper JSON error handling
  • Add new gql and gql_from_file macros for dynamic query handling with compile-time expansion
  • Enhance formatter to handle dynamic parts detection

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
native/graphql_query_native/src/lib.rs Replace deprecated parser API, add structured error types, and implement JSON error formatting
lib/graphql_query/validator.ex Extract validation logic into dedicated module
lib/graphql_query/parser.ex Add utility functions for dynamic parts detection and error formatting
lib/graphql_query/native.ex Add structured error type definitions and update NIF error handling
lib/graphql_query/formatter.ex Enhance formatter to skip dynamic queries
lib/graphql_query/format.ex Extract formatting logic into separate module
lib/graphql_query.ex Major refactor adding gql and gql_from_file macros with dynamic expansion capabilities
README.md Update documentation with new macro usage examples and features
.formatter.exs Add formatter configuration for new macros

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

rockneurotiko and others added 9 commits August 14, 2025 19:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rockneurotiko rockneurotiko merged commit f329a23 into main Aug 15, 2025
2 checks passed
@rockneurotiko rockneurotiko deleted the change_to_macro branch August 18, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants