fix: resolve performance issue and memory leak in table example#294
Open
ahgmn wants to merge 2 commits intorockorager:mainfrom
Open
fix: resolve performance issue and memory leak in table example#294ahgmn wants to merge 2 commits intorockorager:mainfrom
ahgmn wants to merge 2 commits intorockorager:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table_upd event was causing the table example to enter into a redrawing loop whenever the row content was showing. The postEvent would trigger another postEvent and a redraw.
I removed the table_upd event completely as unnecessary, as changing the active_content_fn is enough by itself for the row content to show without needing a table update event.
I also added the missing free for users_buf, mostly to disable the memory leak warnings when exiting the program.