Skip to content

Fix doubled UnregisterCompaction() call #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix doubled UnregisterCompaction() call #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
472747c
Fix doubled UnregisterCompaction() call
rockeet Oct 5, 2024
7a8a0cb
other 2 merge issues
rockeet Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions db/db_impl/db_impl_compaction_flush.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,9 +1907,6 @@ Status DBImpl::ReFitLevel(ColumnFamilyData* cfd, int level, int target_level) {
cfd->compaction_picker()->UnregisterCompaction(c.get());
c.reset();

cfd->compaction_picker()->UnregisterCompaction(c.get());
c.reset();

InstallSuperVersionAndScheduleWork(cfd, &sv_context, mutable_cf_options);

ROCKS_LOG_DEBUG(immutable_db_options_.info_log, "[%s] LogAndApply: %s\n",
Expand Down
2 changes: 0 additions & 2 deletions tools/dump/db_dump_tool.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
// (found in the LICENSE.Apache file in the root directory).


#include "rocksdb/db_dump_tool.h"

#include "rocksdb/db_dump_tool.h"

#include <cinttypes>
Expand Down
2 changes: 0 additions & 2 deletions utilities/compaction_filters/remove_emptyvalue_compactionfilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
// (found in the LICENSE.Apache file in the root directory).


#include "utilities/compaction_filters/remove_emptyvalue_compactionfilter.h"

#include "utilities/compaction_filters/remove_emptyvalue_compactionfilter.h"

#include <string>
Expand Down