Replace calls to "vm_compute in hyps" by plain calls to vm_compute.#138
Open
silene wants to merge 1 commit intorocq-community:masterfrom
Open
Replace calls to "vm_compute in hyps" by plain calls to vm_compute.#138silene wants to merge 1 commit intorocq-community:masterfrom
silene wants to merge 1 commit intorocq-community:masterfrom
Conversation
The terms are of type "Internal.T env_sym", so invoking "vm_compute in" on them ends up strongly normalizing the function env_sym, which explodes. By using "eval vm_compute" instead, only the bodies get strongly normalized.
Contributor
|
Is this different from |
Member
|
@silene fine by me, do you advise this should be merged right away? |
Author
|
@SkySkimmer No, it is the same. (That said, the location of the casts in the produced proof term might be slightly different. I never remember the precise rules for @palmskog No hurry. It will only make things faster for users of |
Contributor
|
Until rocq-prover/rocq#18796 there is no cast when using |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terms are of type
Internal.T env_sym, so invokingvm_compute inon them ends up strongly normalizing the functionenv_sym, which explodes. By usingeval vm_computeinstead, only the bodies get strongly normalized.This is related to rocq-prover/rocq#18917.