Merged
Conversation
910ad33 fix: Make flake8 happy (vs. E501 line too long)
202e83e feat: Interpolate `{vars[…]}, {matrix[…]}` in `context:, dockerfile:`
f0373f2 test: Add test_subset_comma_list
5844e6b docs(README.md): Use `./keeper.py generate-config --help`
git-subtree-dir: external/docker-keeper
git-subtree-split: 910ad33f962faeb9e00122c52c6cc95e7aca7908
* commit '92a1c3796f69c560bc2e348dde7fdb5ac0ca4420': Squashed 'external/docker-keeper/' changes from 3c2782c..910ad33
This patch happens to be necessary for coq/opam projects that depend on coq-core (for example), and not on coq directly. See-also: rocq-community/gaia#27 (comment)
|
@erikmd LGTM, note that for >= 9.0 we also need rocq-runtime pinned |
Member
Author
|
@proux01 sorry for my late reply
Sure, it was already planned this way: (it can be noted that for simplicity/consistency (to avoid having some occurrence of "coq" in the Rocq repos/images), we decided to have two separated GitHub repos for Docker-Coq < 8.20 and Docker-Rocq >= 9.0, each deployed to a different Docker Hub repository, |
erikmd
added a commit
to rocq-community/docker-base
that referenced
this pull request
May 13, 2025
Cc @CohenCyril @hoheinzollern @proux01 FYI Follows-up: rocq-community/docker-coq#79 Follows-up: rocq-community/docker-rocq#13 Follows-up: rocq-community/docker-rocq#11 Follows-up: rocq-community/docker-rocq#14 Follows-up: math-comp/docker-mathcomp#33 Follows-up: math-comp/docker-mathcomp#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: spotted in rocq-community/gaia#27 (comment)
Cc @proux01 FYI (I plan to merge/monitor this tomorrow)