Skip to content

Change ci_test_dependants to require an explicit allow-list #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lysxia wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change ci_test_dependants to require an explicit allow-list #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7f4db
Change ci_test_dependants to require an explicit allow-list
Lysxia Oct 1, 2025
23868a9
Add -t flag to opam install --deps-only for dependants
Lysxia Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ language: shell
set -ex
sudo chown -R coq:coq /home/coq/${PACKAGE}
opam install ${PACKAGE} -v -y -j ${NJOBS}
{{# ci_test_dependants }}
{{# ci_test_dependants.enabled }}
PINS=$(opam list -s --pinned --columns=package | xargs | tr ' ' ,)
PACKAGES=`opam list -s --depends-on {{ opam_name }}{{^ opam_name }}coq-{{ shortname }}{{/ opam_name }} --coinstallable-with $PINS`
PACKAGES="{{# ci_test_dependants.packages }}{{.}} {{/ ci_test_dependants.packages }}"
if [ -n "$PACKAGES" ]
then opam install -t $PACKAGES
fi
{{/ ci_test_dependants }}
{{/ ci_test_dependants.enabled }}
"
- docker stop COQ # optional
- echo -en 'travis_fold:end:script\\r'
Expand Down
6 changes: 3 additions & 3 deletions config.yml.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,18 @@ jobs:
name: Build, test, and install package
command: opam install -t .
{{& circleci_after_script }}
{{# ci_test_dependants }}
{{# ci_test_dependants.enabled }}
- run:
name: Test dependants
command: |
PINS=$(opam list -s --pinned --columns=package | xargs | tr ' ' ,)
PACKAGES=`opam list -s --depends-on {{ opam_name }}{{^ opam_name }}coq-{{ shortname }}{{/ opam_name }} --coinstallable-with $PINS`
PACKAGES="{{# ci_test_dependants.packages }}{{.}} {{/ ci_test_dependants.packages }}"
for PACKAGE in $PACKAGES
do DEPS_FAILED=false
opam install --deps-only $PACKAGE || DEPS_FAILED=true
[ $DEPS_FAILED == true ] || opam install -t $PACKAGE
done
{{/ ci_test_dependants }}
{{/ ci_test_dependants.enabled }}
- run:
name: Uninstall package
command: opam uninstall .
Expand Down
8 changes: 4 additions & 4 deletions docker-action.yml.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,18 @@ jobs:
opam config list; opam repo list; opam list
endGroup
<%/ ci_extra_dev %>
<%# ci_test_dependants %>
<%# ci_test_dependants.enabled %>
after_script: |
startGroup "Test dependants"
PINS=$(opam list -s --pinned --columns=package | xargs | tr ' ' ,)
PACKAGES=`opam list -s --depends-on <% opam_name %><%^ opam_name %>coq-<% shortname %><%/ opam_name %> --coinstallable-with $PINS`
PACKAGES="<%# ci_test_dependants.packages %><%.%> <%/ ci_test_dependants.packages %>"
for PACKAGE in $PACKAGES
do DEPS_FAILED=false
opam install -y --deps-only $PACKAGE || DEPS_FAILED=true
opam install -y -t --deps-only $PACKAGE || DEPS_FAILED=true
[ $DEPS_FAILED == true ] || opam install -t $PACKAGE
done
endGroup
<%/ ci_test_dependants %>
<%/ ci_test_dependants.enabled %>
<%& action_appendix %>

# See also:
Expand Down
6 changes: 5 additions & 1 deletion ref.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,15 @@ fields:
- README.md
- .travis.yml
- ci_test_dependants:
type: bool
used:
- config.yml
- .travis.yml
- docker-action.yml
item_fields:
- name: enabled
type: bool
- name: packages
type: list
- ci_extra_dev:
type: bool
description: >
Expand Down