Reduce the reliance on PConstraints.ContextSet.t in upper layers #21394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Dec 5, 2025
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Dec 5, 2025
ppedrot
added a commit
to ppedrot/paramcoq
that referenced
this pull request
Dec 5, 2025
ppedrot
added a commit
to ppedrot/rewriter
that referenced
this pull request
Dec 5, 2025
ppedrot
added
the
request: full CI
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Dec 5, 2025
ppedrot
force-pushed
the
reduce-pcontext-api
branch
from
b565cc4 to
67f68ec
Compare
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
the
needs: overlay
Contributor
|
metarocq needs overlay? |
It was exposing a dubious context type when you can get it directly from fresh_level instead.
Weirdly enough, just asserting that the set of elimination constraint is empty in monomorphic definitions is enough to pass the test-suite. If you ask me this is fishy, as it means we never really generate any constraint in this mode. At best we should generate constraints on local sort variables and then collapse them to trivially true ground constraints. This probably means somebody will have to fix things up when we really start using sort polymorphism.
ppedrot
added a commit
to ppedrot/metarocq
that referenced
this pull request
Dec 5, 2025
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
reduce-pcontext-api
branch
from
67f68ec to
bdf1ef7
Compare
coqbot-app
bot
removed
the
request: full CI
ppedrot
added a commit
to ppedrot/Mtac2
that referenced
this pull request
Dec 5, 2025
SkySkimmer
removed
the
needs: overlay
ppedrot
added a commit
to ppedrot/Mtac2
that referenced
this pull request
Dec 5, 2025
Contributor
|
@coqbot merge now |
Contributor
|
@SkySkimmer: You can't merge the PR because it hasn't been approved yet. |
SkySkimmer
approved these changes
Dec 5, 2025
Contributor
|
@coqbot merge now |
Contributor
|
@SkySkimmer: Please take care of the following overlays:
|
SkySkimmer
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Dec 5, 2025
SkySkimmer
added a commit
to rocq-community/paramcoq
that referenced
this pull request
Dec 5, 2025
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Dec 5, 2025
ppedrot
added a commit
to mattam82/Coq-Equations
that referenced
this pull request
Dec 5, 2025
ppedrot
added a commit
to MetaRocq/metarocq
that referenced
this pull request
Dec 5, 2025
JasonGross
pushed a commit
to mit-plv/rewriter
that referenced
this pull request
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reinstate Univ.ContextSet.t where it should have been left and add several assertions where we drop the elimination constraints.
Weirdly enough, just asserting that the set of elimination constraint is empty in monomorphic definitions is enough to pass the test-suite. If you ask me this is fishy, as it means we never really generate any constraint in this mode. At best we should generate constraints on local sort variables and then collapse them to trivially true ground constraints. This probably means somebody will have to fix things up when we really start using sort polymorphism.
Overlays: