Ltac2 abbreviations typecheck at declaration time#21617
Open
SkySkimmer wants to merge 4 commits intorocq-prover:masterfrom
Open
Ltac2 abbreviations typecheck at declaration time#21617SkySkimmer wants to merge 4 commits intorocq-prover:masterfrom
SkySkimmer wants to merge 4 commits intorocq-prover:masterfrom
Conversation
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
added
kind: enhancement
SkySkimmer
force-pushed
the
tac2abbrev-up
branch
from
62d534b to
07072f7
Compare
coqbot-app
bot
removed
request: full CI
SkySkimmer
added a commit
to SkySkimmer/rocq
that referenced
this pull request
Feb 11, 2026
This adds a mode to ltac2 typechecking which accumulates errors instead of raising an exception at the first error. Ltac2 Globalize then uses this mode and ignores the accumulated errors (we could print them instead). The accumulation mode could also be used to provide all errors from an ltac2 expression in regular code in the future (with a flag). Together with rocq-prover#21617 this gets us closer to removing the globalize code (which doesn't work on quotations so should be avoided).
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
tac2abbrev-up
branch
from
07072f7 to
303eca1
Compare
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
needs: overlay
SkySkimmer
added a commit
to SkySkimmer/rocq-ltac2-compiler
that referenced
this pull request
Feb 13, 2026
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
tac2abbrev-up
branch
from
099f60c to
86c4623
Compare
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added a commit
to SkySkimmer/rocq
that referenced
this pull request
Feb 26, 2026
This adds a mode to ltac2 typechecking which accumulates errors instead of raising an exception at the first error. Ltac2 Globalize then uses this mode and ignores the accumulated errors (we could print them instead). The accumulation mode could also be used to provide all errors from an ltac2 expression in regular code in the future (with a flag). Together with rocq-prover#21617 this gets us closer to removing the globalize code (which doesn't work on quotations so should be avoided).
github-actions
bot
added
the
needs: rebase
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
tac2abbrev-up
branch
from
86c4623 to
afaad00
Compare
coqbot-app
bot
removed
needs: rebase
github-actions
bot
added
the
needs: rebase
(only used when unset typed notations, caller also in tac2intern)
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
tac2abbrev-up
branch
from
afaad00 to
d43d444
Compare
coqbot-app
bot
removed
needs: rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means
Ltac2 Abbreviation foo := @foo.Overlays: